[ http://issues.apache.org/jira/browse/XERCESC-1327?page=comments#action_57882 ] Robert Buck commented on XERCESC-1327: --------------------------------------
[1] The specific case where I "detect" a problem is with the PSVIDefs enums. Since PSVI, last I was aware, is not part of any W3 Spec, I see no reason to not change these to camel case. [2] The only reason I actually found this was that a third party library defines these specific ALL_CAPS values as ***EXPRESSIONS***. And this is precisely what really concerns me... If the ALL_CAPS preprocessor macro were not an expression, but a scalar value, what would have been the result? Perhaps an incorrect result? Is that possible? I think it is better to break with a standard to adapt it to a particular programming language, than to kill people. And yes, incorrect results can kill. > Change all enum values from ALLCAPS to MixedCase > ------------------------------------------------ > > Key: XERCESC-1327 > URL: http://issues.apache.org/jira/browse/XERCESC-1327 > Project: Xerces-C++ > Type: Bug > Components: Build > Versions: 2.6.0 > Environment: All > Reporter: Robert Buck > > The enum values in Xerces-C are in ALLCAPS, which violates general > programming practice, which reserves ALLCAPS identifiers for C preprocessor > macros. This is a huge problem for people integrating diverse 3rd-party > libraries and Xerces-C, as the enum values often collide with macro > expressions. The result is thousands of lines of nearly indecipherable errors > being emitted from compilers. > Please change all enum values to "MixedCase". If you happen to be aware of > any other ALLCAPS identifiers in Xerces-C, change those too. > This is very critical. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
