[ http://issues.apache.org/jira/browse/XERCESC-1358?page=comments#action_61985 ] David Bertoni commented on XERCESC-1358: ----------------------------------------
Hi Gareth, sorry I haven't responded to your comments earlier. I'm not sure what the best approach to take. Probably the easiest is to just keep the code as is until we can do some testing (or we get some feedback) to determine if an even hash modulus will be a big problem. Perhaps we can resolve this issue, and open another one to track the problem with the modulus? > RefHashTableOf::rehash() is not exception-safe > ---------------------------------------------- > > Key: XERCESC-1358 > URL: http://issues.apache.org/jira/browse/XERCESC-1358 > Project: Xerces-C++ > Type: Bug > Components: Utilities > Versions: 2.6.0 > Environment: All > Reporter: David Bertoni > Assignee: Gareth Reakes > Attachments: patch.txt > > RefHashTableOf::rehash() modifies its data member in the course of rehashing. > If an exception is thrown during this member function, the object is in an > inconsistent state, which will cause problems when it is destroyed. Also, > there is a chance that memory will leak. > I will provide a patch which does not modify the data members until the > rehashing has complete. It also fixes the potential memory leak. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
