hi,

here is better looking now context patch:

Index: src/org/apache/xerces/impl/XMLScanner.java
===================================================================
RCS file:
/home/cvspublic/xml-xerces/java/src/org/apache/xerces/impl/XMLScanner.
java,v
retrieving revision 1.6
diff -w -c -r1.6 XMLScanner.java
*** src/org/apache/xerces/impl/XMLScanner.java  2001/10/16 19:37:59    
1.6
--- src/org/apache/xerces/impl/XMLScanner.java  2001/10/22 18:54:17
***************
*** 840,846 ****
                      // #x20 and collapsed per the normal rules.
                      fEntityScanner.scanChar();
                      fStringBuffer.append(' ');
!                     fStringBuffer.append((char)c);
                      if (entityDepth == fEntityDepth) {
                          fStringBuffer2.append((char)c);
                      }
--- 840,846 ----
                      // #x20 and collapsed per the normal rules.
                      fEntityScanner.scanChar();
                      fStringBuffer.append(' ');
!                     //fStringBuffer.append((char)c); //ALEK
                      if (entityDepth == fEntityDepth) {
                          fStringBuffer2.append((char)c);
                      }


thanks,

alek




-------- Original Message --------
Subject: Re: [Xerces2] possible bug: end of line handling
Date: Sun, 21 Oct 2001 23:31:53 -0500
From: Aleksander Slominski <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
To: Andy Clark <[EMAIL PROTECTED]>
CC: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>

Andy Clark wrote:

> Aleksander Slominski wrote:
> > the problem is gone for the element content but it seems that still
> > EOL normalization is not working for attribute values: according to
>
> Instead of taking so much time writing up these test files and
> detailing the results, how 'bout just submitting a patch to fix
> the bug? ;)

ok, i will try to fix - i am just  not sure if i do not miss something
obvious (x2 is pretty big :-))

i have modified just one line and it passed all line handling tests:

===================================================================
RCS file:
/home/cvspublic/xml-xerces/java/src/org/apache/xerces/impl/XMLScanner.java,v

retrieving revision 1.6
diff -w -r1.6 XMLScanner.java
843c843
<                     fStringBuffer.append((char)c);
---
>                     //fStringBuffer.append((char)c); //ALEK


but i do not know how to run regressin tests so i could not verify if it
had some other effects...

thanks,

alek



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to