Andy Clark wrote:
Neil Graham wrote:
After thinking about the 4 options I originally posted, I've concluded that
option 1 seems best. It's completely consistent with what we've done
everywhere else in XNI viz. encodings, and makes the startExternal subset
call symmetric with the startDocument call. So to review, I'm proposing
that we change
I don't like option 1 because it's a breaking API change. Anything that changes an existing method's prototype or removes an existing method is destructive and causes a lot of distress for application writers using XNI.
Hi Neil,
I understand your point and you really explained well about the pros & cons of each approach. As you mentioned too, the downside of this approach is that it breaks compatibility and IMO its a big thing which should be avoided.
I agree with Andy that breaking compatibility is pain for all the developers who has developed their applications using XNI. So, I am also not in favor of this change.
4. We could amend the XMLLocator interface by adding a method like public String getEncoding()
I don't mind this addition because I figure that we'll probably end up adding something like this anyway. And this change does not break existing applications unless those applications implement their own XMLLocator class. And even then, adding this method in their code still allows it to be used by people using older versions of Xerces.
from the XMLLocator. We'd also have to make sure to update the locator implementation at every entity change, which could impact performance slightly. Finally, I'd submit that it's trivial to implement the SAX
I don't think so.
The XMLEntityManager.ScannedEntity class already keeps track of the encoding of the entity. So there is no "updating" required as entities are popped off of the entity manager's scanned-entity stack.
Right. Encoding information was always available and it just needs to be passed.
thanks, Neeraj
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
