http://bugzilla.xfce.org/show_bug.cgi?id=5557
--- Comment #6 from Yves-Alexis Perez <[email protected]> 2009-07-12 10:13:17 UTC --- (In reply to comment #5) > Good point. checkbashisms against xinitrc reports: > > cor...@hidalgo: checkbashisms > debian/xfce/desktop/xfce-utils/scripts/xinitrc.in > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 4 > ($UID should be "$(id -ru)"): > if test "x$UID" = "x"; then false positive, since we set it at that time. > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 31 > (type): > if type xdg-user-dirs-update >/dev/null 2>&1; then not sure how to fix that :/ > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 36 > (should be '.', not 'source'): > source "$XDG_CONFIG_HOME/user-dirs.dirs" > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 91 > ($UID should be "$(id -ru)"): we already set it before, so false positive > if test $UID -gt 0 -a -z "$VNCSESSION"; then > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 168 > (type): > type "$trycmd" >/dev/null 2>&1 || continue again, not sure how to fix it. > possible bashism in debian/xfce/desktop/xfce-utils/scripts/xinitrc.in line 172 > (type): > if test "$cmd" && type "$cmd" >/dev/null 2>&1; then and again. So all in all, the only fixable one is the source / . which is fairly easy to do. I'll check how to fix the “type” one. For the export= stuff, it's not detected by checkbashism, so I *guess* it's something POSIX and thus sould be kept? (but if it fixes other problems, why not). Cheers, -- Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] http://foo-projects.org/mailman/listinfo/xfce-bugs
