[Xfce4-commits] Fix memleak in cover-art loading

[Simon Steinbeiss]

Updating branch refs/heads/master
         to b882d5f2fa79935ca57fc65f8bf43827f2cbb26d (commit)
       from 92db1a9813c6a3923b15a28d5ff8a8fb1c9ed9a1 (commit)

commit b882d5f2fa79935ca57fc65f8bf43827f2cbb26d
Author: Simon Steinbeiss <simon.steinbe...@elfenbeinturm.at>
Date:   Fri Nov 30 16:42:32 2012 +0100

    Fix memleak in cover-art loading

 src/parole-player.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/parole-player.c b/src/parole-player.c
index 4afde61..9a11ef4 100644
--- a/src/parole-player.c
+++ b/src/parole-player.c
@@ -1575,7 +1575,7 @@ parole_player_media_tag_cb (ParoleGst *gst, const 
ParoleStream *stream, ParolePl
     gchar *album;
     gchar *artist;
     gchar *year;
-    GdkPixbuf *image = NULL;
+    GdkPixbuf *image = NULL, *cover = NULL;
     
     if ( player->priv->row )
     {
@@ -1628,13 +1628,13 @@ parole_player_media_tag_cb (ParoleGst *gst, const 
ParoleStream *stream, ParolePl
        image = parole_stream_get_image(G_OBJECT(stream));
        if (image)
        {
-           image = gdk_pixbuf_scale_simple(image, 200, 200, 
GDK_INTERP_BILINEAR);
-           gtk_image_set_from_pixbuf(GTK_IMAGE(player->priv->audiobox_cover), 
image);
-           g_object_unref(G_OBJECT(image));
+           cover = gdk_pixbuf_scale_simple(image, 200, 200, 
GDK_INTERP_BILINEAR);
+           gtk_image_set_from_pixbuf(GTK_IMAGE(player->priv->audiobox_cover), 
cover);
+           g_object_unref(cover);
+           g_object_unref(image);
     }
        else
        gtk_image_set_from_icon_name(GTK_IMAGE(player->priv->audiobox_cover), 
"audio-x-generic", GTK_ICON_SIZE_ARTWORK_FALLBACK);
-
     }
 }
 
_______________________________________________
Xfce4-commits mailing list
Xfce4-commits@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce4-commits