Ron: I can only guess the approach he chose might require less calls to #undef ... and either approach would have worked the same but now for the sake of making things simpler to compare with any changes features vs Harbour it just keep things as simple as possible.
At this point I'd say Brian would prefer to keep the new constant name rather than make current and future code sync less painful. Regards, Ron Pinkas wrote: > Sorry, I still can't understand. I see no reason why the name must be > changed. What would be the problem with: > > #if ADS_REQUIRE_VERSION == 5 > #undef ADS_REQUIRE_VERSION > #define ADS_REQUIRE_VERSION 500 > #elif ADS_REQUIRE_VERSION == 6 > #undef ADS_REQUIRE_VERSION > #define ADS_REQUIRE_VERSION 600 > ... > > Ron > > On May 20, 2008, at 10:42 AM, Luis Krause Mantilla wrote: > > >> Ron: >> >> I believe it's due to the fact that it would be difficult to >> compare single digit vs triple digit values in the constants >> being that they are not strings, but also in the way Viktor >> implemented the auto-detect feature: >> >> From rddads.h in the harbour svn: >> >> #include "ace.h" >> >> /* Autodetect ACE version. */ >> #if defined(ADS_NOTIFICATION_CONNECTION) >> #define _ADS_LIB_VERSION 900 /* or upper */ >> #elif defined(ADS_UDP_IP_CONNECTION) >> #define _ADS_LIB_VERSION 810 /* or upper */ >> #elif defined(ADS_REPLICATION_CONNECTION) >> #define _ADS_LIB_VERSION 800 /* or upper */ >> #elif defined(ADS_NOT_AUTO_OPEN) >> #define _ADS_LIB_VERSION 710 /* or upper */ >> #elif defined(ADS_FTS_INDEX_ORDER) >> #define _ADS_LIB_VERSION 700 /* or upper */ >> #elif defined(ADS_COMPRESS_ALWAYS) >> #define _ADS_LIB_VERSION 620 /* or upper */ >> #elif defined(ADS_USER_DEFINED) >> #define _ADS_LIB_VERSION 611 /* or upper */ >> #else >> #define _ADS_LIB_VERSION 500 >> #endif >> >> /* Compatibility ACE version override. >> Usage is discouraged and unnecessary unless we want to >> override autodetection. For the latter, ADS_LIB_VERSION >> is recommended. If ADS_LIB_VERSION is #defined, >> ADS_REQUIRE_VERSION will be ignored. [vszakats] */ >> #if !defined( ADS_LIB_VERSION ) >> #if ADS_REQUIRE_VERSION == 5 >> #define ADS_LIB_VERSION 500 >> #elif ADS_REQUIRE_VERSION == 6 >> #define ADS_LIB_VERSION 600 >> #elif ADS_REQUIRE_VERSION == 7 >> #define ADS_LIB_VERSION 700 >> #elif ADS_REQUIRE_VERSION == 8 >> #define ADS_LIB_VERSION 800 >> #elif ADS_REQUIRE_VERSION == 9 >> #define ADS_LIB_VERSION 900 >> #endif >> #endif >> >> Regards, >> >> Ron Pinkas wrote: >> >>>> ADS_REQUIRE_VERSION becomes obsolete so you should not >>>> define it. Instead, you would use ADS_LIB_VERSION as in >>>> >>>> SET ADS_LIB_VERSION=700 >>>> or >>>> SET ADS_LIB_VERSION=710 >>>> >>>> depending if your users have 7.0 or 7.1 >>>> >>>> And then build rddads.lib >>>> >>>> >>> This appears to be a mindless change - why would the define name >>> NEED to be changed? >>> >>> Ron >>> >>> --------------------------------------------------------------------- >>> ---- >>> This SF.net email is sponsored by: Microsoft Defy all challenges. >>> Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/ >>> vse0120000070mrt/direct/01/ >>> _______________________________________________ >>> xHarbour-developers mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/xharbour-developers >>> >>> >>> >> -- >> Luis Krause Mantilla >> lkrausem at shaw dot ca >> luis_krause at hotmail dot com >> "May the Source be with GNU" >> >> >> >> > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > xHarbour-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/xharbour-developers > > -- Luis Krause Mantilla lkrausem at shaw dot ca luis_krause at hotmail dot com "May the Source be with GNU" ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ xHarbour-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xharbour-developers
