On Thursday, July 18, 2002, at 09:27 AM, Fernando Padilla wrote:
Hello.
So I'm going through the code to really learn what is really going on, so I can add features. As I am going I'll be doing janitorial work.
Cleaning out unused/useless code. Looking for conceptual bugs. Refactoring and Streamlining.
So just looking at Kernel and Configuration, I've found a lot of little modifications to be made:
I wouldn't spend a lot of time on the code in org.apache.xindice.server (including Kernel). Other then org.apache.xindice.server.rpc, I'm hoping we can cut almost everything in there. I already have the system running under a simple HTTP server borrowed from the XML-RPC library. It literally took me five minutes to get it to work. So hopefully once we decide on the final direction for server framework it won't be too tough to convert over.
Otherwise if you take a refactoring eye to that code, you're going to find a ton of stuff that isn't even used. It all came over from the Juggernaut code, and it's constantly annoyed me that there is so much unused code in there.
Configuration - had a unused 'Modified' Map, and thus defunct 'setDirty' method. - all of the 'setValue' methods had bad signatures - and as an aside, these are all unused.
Kernel - system.xml parsing code had minor cruft, unused variables, etc - it exposed a Runnable interface, which is not good programming - moved to internal class - then saw that the runnable interface was just for task scheduling - replaced with java.util.Timer and java.util.TimerTask implementation of Task scheduling.
So except for the java.util.Timer, it was all interchangeable modifications. Could someone get me feedback and/or check these in. I would really appreciate it because I don't like being too much out of sync with CVS.
OK, I'll look at them.
Fernando
Kimbro Staken Java and XML Software, Consulting and Writing http://www.xmldatabases.org/ Apache Xindice native XML database http://xml.apache.org/xindice XML:DB Initiative http://www.xmldb.org
