Hello.

I found another class to clean out.

org.apache.xindice.core.data.Variant
org.apache.xindice.core.data.Types

This was supposed to be an implementation of a class to help translate 
between different data types.  It had a few conceptual bugs, and it was 
only used at one or two places in the code, so I suggest to just remove 
it.

Attached is the patch to modify the code that uses the Variant class.  
After that is in, you can remove the classes themselves.

Fernando


? Xindice.war
? deploy
? docs/api
? java/classes
? java/lib/xindice.jar
Index: java/src/org/apache/xindice/core/Collection.java
===================================================================
RCS file: 
/home/cvspublic/xml-xindice/java/src/org/apache/xindice/core/Collection.java,v
retrieving revision 1.4
diff -u -r1.4 Collection.java
--- java/src/org/apache/xindice/core/Collection.java    21 Jul 2002 02:52:17 
-0000      1.4
+++ java/src/org/apache/xindice/core/Collection.java    22 Jul 2002 15:03:34 
-0000
@@ -542,9 +542,9 @@
          catch ( Exception e ) {
             throw new DBException(FaultCodes.COL_CANNOT_STORE, "Error storing 
Document '"+key+"'");
          }
+      } else {
+         value = new Value( TextWriter.toString( document ) );
       }
-      else
-         value = new Value(new Variant(document).toString());
 
       flushSymbolTable();
       
Index: java/src/org/apache/xindice/xml/dom/ElementImpl.java
===================================================================
RCS file: 
/home/cvspublic/xml-xindice/java/src/org/apache/xindice/xml/dom/ElementImpl.java,v
retrieving revision 1.3
diff -u -r1.3 ElementImpl.java
--- java/src/org/apache/xindice/xml/dom/ElementImpl.java        21 Jul 2002 
02:52:18 -0000      1.3
+++ java/src/org/apache/xindice/xml/dom/ElementImpl.java        22 Jul 2002 
15:03:34 -0000
@@ -255,7 +255,7 @@
                      else if ( result instanceof Node )
                         obj = doc.importNode((Node)result, true);
                      else
-                        obj = doc.createTextNode(new 
Variant(result).toString());
+                        obj = doc.createTextNode( TextWriter.toString( result 
) );
                   }
                   break;*/
 

Reply via email to