While browsing the code (and trying to understand it) I've seen a lot of code like this one:

  public void methodname() throws XMLDBException {
    code_that_can_throw_exeception;
  }

Should we encapsulate the call between a try/catch block, like this:

  public void methodname() throws XMLDBException {
    try {
      code_that_can_throw_exeception
    } catch (Exception e) {
      throw new XMLDBException(ErrorCodes.UNKNOWN_ERROR, e);
    }
  }

To respect the signature (and since we have chained exceptions)? This is of course only applicable for unchecked exceptions.

-Vladimir

--
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice



Reply via email to