Vladimir,
I hope to address your concerns with the metadata code. I am working on
documentation and tests now. (I might point out that there's a lot of
xindice that isn't documented.... like how to run the tests or use PMD ;) I
am unfamiliar with PMD, which explains my not bothering to run it. I've
already sent a message about not being able to run the tests. Can you help
me solve that problem? Also, can you point me to documentation (either ours
or others) which describes in a step by step manner how to setup and run pmd
in the context of Xindice?
Now that the basic code is in CVS, I hope that other developers will be
able use and enhance the code with lots of cool stuff. After all, that what
this is all for. As soon as I learn more about junit and pmd, I'll try to
fix the problems you noted below. The journey of a thousand miles begins
with a single step. I hope this code is that first step. It certainly
isn't the full journey tho.
dave
-----Original Message-----
From: Vladimir R. Bossicard [mailto:[EMAIL PROTECTED]
Sent: Friday, December 27, 2002 12:08 PM
To: [EMAIL PROTECTED]
Subject: Re: cvs commit:
xml-xindice/java/src/org/apache/xindice/server/rpc/messages
GetCollectionMeta.java GetDocumentMeta.java SetCollectionMeta.java
SetDocumentMeta.java
> Modified: config system.xml
> java/src/org/apache/xindice/core Collection.java
> Database.java
> java/src/org/apache/xindice/server/rpc
> RPCDefaultMessage.java
> Added: java/src/org/apache/xindice/core MetaSystemCollection.java
> java/src/org/apache/xindice/core/meta MetaData.java
> TimeRecord.java package.html
> java/src/org/apache/xindice/server/rpc/messages
> GetCollectionMeta.java GetDocumentMeta.java
> SetCollectionMeta.java SetDocumentMeta.java
> Log:
> Implementation of MetaData storage for Xindice. This
> topic has been extensively discussed on the mailing list. Please
> see the following threads from the mailing list for more information
1) sorry to always repeat the same thing but "Where are the tests"?
Can't this code fail?
2) I've set up PMD to check for code quality and it looks like you
didn't bother run it:
org/apache/xindice/core/MetaSystemCollection.java 63 Avoid duplicate
imports such as 'org.apache.xindice.util.Configuration'
org/apache/xindice/core/MetaSystemCollection.java 216 Avoid empty catch
blocks
org/apache/xindice/core/MetaSystemCollection.java 286 Avoid empty catch
blocks
org/apache/xindice/core/MetaSystemCollection.java 77 Avoid unused
imports such as 'File'
org/apache/xindice/core/meta/MetaData.java 634 Avoid unused local
variables such as 'prefix'
org/apache/xindice/core/meta/TimeRecord.java 63 Avoid unused imports
such as 'Hashtable'
org/apache/xindice/server/rpc/messages/GetCollectionMeta.java 70 Avoid
unused imports such as 'DOMImplementationImpl'
org/apache/xindice/server/rpc/messages/GetCollectionMeta.java 63 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/GetDocumentMeta.java 63 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/SetCollectionMeta.java 64 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/SetDocumentMeta.java 64 Avoid
unused imports such as 'Database'
3) where is the documentation? Is metadata such an easy topic?
Last mail from the Grinch.
-Vladimir
--
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice
