vgritsenko 2003/12/24 19:48:11
Modified: java/src/org/apache/xindice/xml/dom ContainerNodeImpl.java
DOMCompressor.java DOMParser.java DocumentImpl.java
ElementImpl.java ProcessingInstructionImpl.java
Log:
Reviewing TODOs
Revision Changes Path
1.15 +3 -4
xml-xindice/java/src/org/apache/xindice/xml/dom/ContainerNodeImpl.java
Index: ContainerNodeImpl.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/ContainerNodeImpl.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- ContainerNodeImpl.java 12 Aug 2003 02:57:29 -0000 1.14
+++ ContainerNodeImpl.java 25 Dec 2003 03:48:10 -0000 1.15
@@ -157,8 +157,7 @@
while (bis.available() > 0) {
int pos = bis.getPos();
- /* TODO why is it used for? byte signature = */
- in.readSignature();
+ in.readSignature(); // Skip signature
int len = in.readContentSize();
if (len == 0) {
len = 1;
1.10 +2 -3
xml-xindice/java/src/org/apache/xindice/xml/dom/DOMCompressor.java
Index: DOMCompressor.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/DOMCompressor.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- DOMCompressor.java 9 Aug 2003 21:19:52 -0000 1.9
+++ DOMCompressor.java 25 Dec 2003 03:48:10 -0000 1.10
@@ -145,7 +145,6 @@
case Node.ATTRIBUTE_NODE:
{
Attr attr = (Attr) node;
- /* TODO why is it used for? String elem = */
attr.getOwnerElement().getNodeName();
String nsURI = attr.getNamespaceURI();
short symbolID;
if (nsURI != null) {
1.13 +4 -3
xml-xindice/java/src/org/apache/xindice/xml/dom/DOMParser.java
Index: DOMParser.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/DOMParser.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- DOMParser.java 9 Aug 2003 21:19:52 -0000 1.12
+++ DOMParser.java 25 Dec 2003 03:48:10 -0000 1.13
@@ -95,6 +95,8 @@
*/
public final class DOMParser extends DefaultHandler implements DeclHandler,
LexicalHandler {
+ // TODO: Improve exception handling
+
private static final Log log = LogFactory.getLog(DOMParser.class);
private SAXParser sp;
@@ -435,5 +437,4 @@
String s = new String(ch, start, length);
context.appendChild(doc.createComment(s));
}
-
}
1.14 +2 -4
xml-xindice/java/src/org/apache/xindice/xml/dom/DocumentImpl.java
Index: DocumentImpl.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/DocumentImpl.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- DocumentImpl.java 6 Dec 2003 22:44:36 -0000 1.13
+++ DocumentImpl.java 25 Dec 2003 03:48:10 -0000 1.14
@@ -196,8 +196,6 @@
}
public void setCaching(boolean caching) {
- // TODO delete String cache = DBDocument.CACHE;
-
int size = childNodes.getLength();
for (int i = 0; i < size; i++) {
Node n = childNodes.item(i);
1.17 +3 -4
xml-xindice/java/src/org/apache/xindice/xml/dom/ElementImpl.java
Index: ElementImpl.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/ElementImpl.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- ElementImpl.java 12 Aug 2003 02:57:29 -0000 1.16
+++ ElementImpl.java 25 Dec 2003 03:48:10 -0000 1.17
@@ -202,8 +202,7 @@
in.readSignature();
in.readContentSize();
- /* TODO why is it used for? short elemSymbol = */
- in.readShort();
+ in.readShort(); // Some "elemSymbol" - symbol ID?
int attrCount = in.readAttributeCount();
for (int i = 0; i < attrCount; i++) {
1.13 +3 -4
xml-xindice/java/src/org/apache/xindice/xml/dom/ProcessingInstructionImpl.java
Index: ProcessingInstructionImpl.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/xml/dom/ProcessingInstructionImpl.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ProcessingInstructionImpl.java 12 Aug 2003 02:57:29 -0000 1.12
+++ ProcessingInstructionImpl.java 25 Dec 2003 03:48:10 -0000 1.13
@@ -112,8 +112,7 @@
XMLCompressedInput xci = new XMLCompressedInput(bis, st);
xci.readSignature(); // Skip The Signature
- /* TODO why is it used for? int size = */
- xci.readInt();
+ xci.readInt(); // Skip size
byte[] buf = new byte[bis.available()];
xci.read(buf);
