vgritsenko 2003/12/25 11:33:24
Modified: java/src/org/apache/xindice/server/rpc/messages
CreateIndexer.java GetIndexerConfiguration.java
RemoveCollection.java
Log:
Remove couple of done TODOs, add couple of FIXMEs
Revision Changes Path
1.7 +2 -3
xml-xindice/java/src/org/apache/xindice/server/rpc/messages/CreateIndexer.java
Index: CreateIndexer.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/server/rpc/messages/CreateIndexer.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- CreateIndexer.java 7 Aug 2003 20:13:23 -0000 1.6
+++ CreateIndexer.java 25 Dec 2003 19:33:23 -0000 1.7
@@ -94,7 +94,6 @@
throw new Exception("Unable to parse Indexer configuration");
}
- // TODO: should extract the name from the document. done.
String name = doc.getDocumentElement().getAttribute("name");
message.put(NAME, name);
}
1.8 +3 -7
xml-xindice/java/src/org/apache/xindice/server/rpc/messages/GetIndexerConfiguration.java
Index: GetIndexerConfiguration.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/server/rpc/messages/GetIndexerConfiguration.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- GetIndexerConfiguration.java 7 Aug 2003 20:13:23 -0000 1.7
+++ GetIndexerConfiguration.java 25 Dec 2003 19:33:23 -0000 1.8
@@ -81,21 +81,17 @@
}
Hashtable result = new Hashtable();
-
- // TODO: figure out what goes here. done.
try {
Collection col = getCollection((String) message.get(COLLECTION));
Indexer idx = col.getIndexer((String) message.get(NAME));
if (idx != null) {
-
result.put(RESULT, "yes");
} else {
-
result.put(RESULT, "no");
}
} catch (Exception e) {
-
+ // FIXME "No such collection" is when col == null
/* No such collection */
result.put(RESULT, "no");
}
1.7 +3 -4
xml-xindice/java/src/org/apache/xindice/server/rpc/messages/RemoveCollection.java
Index: RemoveCollection.java
===================================================================
RCS file:
/home/cvs/xml-xindice/java/src/org/apache/xindice/server/rpc/messages/RemoveCollection.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- RemoveCollection.java 7 Aug 2003 20:13:23 -0000 1.6
+++ RemoveCollection.java 25 Dec 2003 19:33:23 -0000 1.7
@@ -69,7 +69,6 @@
* @version CVS $Revision$, $Date$
*/
public class RemoveCollection extends RPCDefaultMessage {
- // TODO: should have a simple way to validate params. done.
public Hashtable execute(Hashtable message) throws Exception {
@@ -91,7 +90,7 @@
result.put(RESULT, "yes");
} catch (Exception e) {
-
+ // FIXME "No such collection" is when col == null
/* No such collection... */
result.put(RESULT, "no");
}
