On Sun, 6 Apr 2003, Barzilai Spinak wrote:

> As I explain in the disclaimer, I'm very new to both Xindice and Cocoon,
> so I may have done a lot of conceptual mistakes.

The only comment I'd have is:

  You have installed Tomcat 4 and it is installed under /var/tomcat4 and
  have exported the TOMCAT_HOME variable.  (It normally starts on port
  8080, so if you go to http://yourhost:8080 you will get your local
  Tomcat page)

You don't need to talk about /var/tomcat4 for the same reason that you
don't mention the directory java is installed in - because when JAVA_HOME
and $TOMCAT_HOME are set, it doesn't matter.

This means that step 1 in the build process should be modified to
something like "if you don't want to use TOMCAT_HOME, ..."

You also have typos: <source-hanlder> should be <source-handler>.

Other than that, looks pretty good to me, so far! Can't wait to try it out
on a Cocoon site :-)

Vladimir, your recent integration tests stop CVS from building -- any
chance you could either roll them back until the problems are fixed, or
commit the fixes?

    [javac] 
/home/savs/cvs-apache/xml-xindice/java/tests/src/org/apache/xindice/integration/client/services/XUpdateQueryTest.java:74:
 setUp() in org.apache.xindice.integration.client.services.XUpdateQueryTest 
cannot override setUp() in 
org.apache.xindice.integration.client.AbstractXmlDbClientTest; attempting to 
assign weaker access privileges; was public
    [javac]     protected void setUp()

Cheers,

Andrew.

-- 
Andrew Savory                                Email: [EMAIL PROTECTED]
Managing Director                              Tel:  +44 (0)870 741 6658
Luminas Internet Applications                  Fax:  +44 (0)700 598 1135
This is not an official statement or order.    Web:    www.luminas.co.uk

Reply via email to