Great, thanks for the patch. I'll apply it for the next release.
On Mon, Jan 14, 2002 at 09:10:12PM -0800, Steve Slaven wrote:
> I don't know if this has been addressed yet, but as of today I still saw
> it on the buglist at x.mame.net. This addresses the problem of going to
> DGA fullscreen mode, pausing, and losing sound. I figured that DGA might
> do some monkeying around, like fork/exec'ing or something, along the lines
> of creating a dup'd fd of the /dev/dsp fd. So I wrapped
> sysdep_update_display call where it detects if the mode needs to be
> changed with osd_sound_enable() using 0 and 1 to turn off sound before the
> switch and turn it back on after the switch of video mode. The bug was
> minor for me until I recently got an x-arcade stick, very cool imho. :)
> Anyways, the patch is below, in diff -c format. This seems to have
> cleared up the issue for me, for pausing, saving, and loading, so now
> playing 15 mins at a time during break still lets me creep forward using
> save/load without losing the benefit of sound.
>
> Great work on the port guys, btw, excellent piece of software.
>
> *** src/unix/video-drivers/x11.c Mon Jan 14 20:58:30 2002
> --- ../xmame-orig/xmame-0.57.1/src/unix/video-drivers/x11.c Tue Jan 1 18:45:56
>2002
> ***************
> *** 196,207 ****
>
> if (new_video_mode != x11_video_mode && mode_available[new_video_mode])
> {
> - /* Close sound, my guess is DGA somehow (perhaps fork/exec?) makes
> - the filehandle open twice, so closing it here and re-openeing after
> - the transition should fix that. Fixed it for me anyways.
> - -- Steve [EMAIL PROTECTED] */
> - osd_sound_enable( 0 );
> -
> (*x_func[x11_video_mode].close_display)();
> if ((*x_func[new_video_mode].create_display)(bitmap_depth) != OSD_OK)
> {
> --- 196,201 ----
> ***************
> *** 238,246 ****
> sysdep_mouse_poll ();
> sysdep_mouse_poll ();
> }
> -
> - /* Re-enable sound */
> - osd_sound_enable( 1 );
> }
>
> (*x_func[x11_video_mode].update_display) (bitmap);
> --- 232,237 ----
>
> Thanks,
> Steve
>
> +-----------------------------------------------------------------------+
> To err is human; to really screw things up requires the root password
> +-----------------------------------------------------------------------+
> * Horizon Distribution Inc. *
> Steve Slaven <[EMAIL PROTECTED]> * (509)453-3181 EXT 254
> Webmaster / MIS Programmer / All Around Computer Department
> Company Website: http://horizondistribution.com
> Personal Website: http://hoopajoo.net
> +-----------------------------------------------------------------------+
>
>
> _______________________________________________
> Xmame mailing list
> [EMAIL PROTECTED]
> http://toybox.twisted.org.uk/mailman/listinfo/xmame
_______________________________________________
Xmame mailing list
[EMAIL PROTECTED]
http://toybox.twisted.org.uk/mailman/listinfo/xmame
