On Mon, Nov 03, 2008 at 09:38:03PM +0200, Roumen Petrov wrote: > - configure.in: macro AC_LIBTOOL_WIN32_DLL is no more required. It is > for about 7 years old GNU compiler(gcc version about 2.9x) where we has > to use dlltool to create shared libraries. I could not found reason to > include it (year is 2008 and gcc(mingw version) is 3.5x).
I'm very sorry but this information is plain wrong. AC_LIBTOOL_WIN32_DLL is required otherwise libtool will assume that the package library cannot build a DLL and won't build one. I have just now verified this is the case with our toolchain (gcc 4.3.2, libtool 1.5.26). > - LDFLAGS: for mingw host configure script is set and substitute > variable WIN32_EXTRA_LDFLAGS with flag "-no-undefined". Why the patch > don't use it ? Also why the patch don't set it in libexslt/Makefile.am > and python/Makefile.am ? We didn't build libexslt or python bindings, but that part of the patch looks good. > Index: configure.in > =================================================================== > --- configure.in (revision 1492) > +++ configure.in (working copy) > @@ -3,7 +3,6 @@ > AC_INIT(libxslt/xslt.c) > AM_CONFIG_HEADER(config.h) > AC_CANONICAL_HOST > -AC_LIBTOOL_WIN32_DLL > AC_GNU_SOURCE You need to revert this bit. Even if AC_LIBTOOL_WIN32_DLL isn't required in some future version of libtool, it does no harm to have this, and it's required by our cross-compiler. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v _______________________________________________ xml mailing list, project page http://xmlsoft.org/ [email protected] http://mail.gnome.org/mailman/listinfo/xml
