On Wed, Jul 28, 2010 at 11:44 AM, Daniel Veillard wrote: > On Thu, Jul 22, 2010 at 02:38:16PM +0200, Csaba Raduly wrote: >> Anyway, here's a revised version: >> --- xmlschemastypes2.c 2010-07-21 13:17:12.229467800 +0200 >> +++ xmlschemastypes.c 2010-07-22 14:00:05.965759600 +0200 (snip) >> + if (digits_before + digits_after == 0) >> + goto return1; > > Okay that patch looks fine, except for mail mangling and code format, > so I applied it manually, look fine, passes regtests, so pushed to git,
I think Andrew Nosenko is right, it would be better to test these separately and not added together: if (digits_before==0 && digits_after==0) goto return1; -- Life is complex, with real and imaginary parts. "Ok, it boots. Which means it must be bug-free and perfect. " -- Linus Torvalds "People disagree with me. I just ignore them." -- Linus Torvalds _______________________________________________ xml mailing list, project page http://xmlsoft.org/ [email protected] http://mail.gnome.org/mailman/listinfo/xml
