The change to VC10\config.h looks good and will avoid problems with VS 2015 if anybody uses that file in the future.
Rotting in multiple directories is the remaining problem. I don't know if libxml still supports VS 10, or if anybody is using VC10\config.h, but Chromium would certainly have no objections to that directory being deleted and include\win32config.h being the canonical version. If so then this line should probably be added to include\win32config.h: #define HAVE_STDINT_H These two lines create defines that are needed for some features. Their presence or absence does not affect us and I don't know if the NOP cast they create is appropriate, but I'd say leave them in include\win32config.h: #define SEND_ARG2_CAST #define GETHOSTBYNAME_ARG_CAST If anybody has any more information or recommendations about these defines, please share. So... 1) Committed change looks good. 2) Could also add #define HAVE_STDINT_H to include\win32config.h 3) Could also delete VC10 directory. On Fri, Mar 11, 2016 at 12:13 AM, Daniel Veillard <veill...@redhat.com> wrote: > On Mon, Mar 07, 2016 at 02:15:28PM -0800, Peter Kasting wrote: > > I echo Bruce's request for a single upstream Windows config file. It > looks > > like include/win32config.h is older; win32/VC10/config.h seems to have > only > > its initial addition in its log. It looks like that addition happened > here: > > > > > https://git.gnome.org/browse/libxml2/commit/?id=066c69777207436e3517d1b930a97f0e0a8aa060 > > > > This seems to have been a convenience for > > https://bugzilla.gnome.org/show_bug.cgi?id=666491 (see > > https://bugzilla.gnome.org/show_bug.cgi?id=666491#c3 , "This is a > different > > and more convenient approach to libxml2 usage, than the nmake approach"), > > but it's not clear to me that libxml wants to do this sort of thing. In > > https://bugzilla.gnome.org/show_bug.cgi?id=666491#c5 , Daniel notes > "Adding > > a VC10 subdir under win32 is a bit heavy, I hope there won't be a new one > > for each new version of the Microsoft tools." Those fears seem to me to > be > > somewhat confirmed; because Microsoft has changed things about the > project > > format, I believe the .vcxproj files in this directory wouldn't serve > > directly for all later versions of MSVC. So this is really a "Visual > > Studio 2010 only" directory. > > <grin/> > > > To me, this whole directory should be nuked, and include/win32config.h > > updated (see my notes below). People using this directory should either > > carry their own project/build files (as Chromium does) or use the > existing > > nmake method. libxml2 shouldn't be responsible for carrying this sort of > > thing, especially when it's for one version of one compiler on one > platform. > > I never use Windows, so really can't comment on the *right* approach > there > > > Another possibility is for this directory to remain, and further > > directories be added for other MSVC versions (which seems unappealing). > > instead of having code rot in one directory we would have multiple > version rotting in multiple directories, unappealing indeed ! > > > In any case, I think win32config.h should be updated; see below for my > > responses to Bruce's comments about the differences between the configs. > > Sure, if people who are using the Windows platform could comment > I will follow what people suggest, > > so feedback welcome ! > > Daniel > > > On Mon, Mar 7, 2016 at 1:47 PM, Bruce Dawson <brucedaw...@google.com> > wrote: > > > > > #define HAVE_STDINT_H > > > > > > > I believe this line is correct for MSVC 2010+. If libxml doesn't support > > anything earlier, then that line should be in win32config.h as-is. > > Otherwise, it should probably be in but with an appropriate _MSC_VER > check. > > > > #define SEND_ARG2_CAST > > > #define GETHOSTBYNAME_ARG_CAST > > > > > > > I think these must be defined if nano{http,ftp}.* are built. If these > are > > ever built on Windows, win32config.h should include these lines. > > > > PK > > > _______________________________________________ > > xml mailing list, project page http://xmlsoft.org/ > > xml@gnome.org > > https://mail.gnome.org/mailman/listinfo/xml > > > -- > Daniel Veillard | Open Source and Standards, Red Hat > veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > http://veillard.com/ | virtualization library http://libvirt.org/ > -- Bruce Dawson
_______________________________________________ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
