Just wanted to follow up... Roumen does this PR look good to you now? Aleksey
On 5/22/17 6:25 AM, Peter Budai wrote: > Hi Roumen, > > > > I have added this additional change to the PR, pls have a look at that. > > > > Best regards, > > > > Peter > > > > *Von: *Roumen Petrov <mailto:xml...@roumenpetrov.info> > *Gesendet: *20 May 2017 14:15 > *An: *Peter Budai <mailto:peterbu...@hotmail.com>; xmlsec@aleksey.com > <mailto:xmlsec@aleksey.com> > *Betreff: *Re: [xmlsec] MinGW build pull request > > > > Hi Peter, > > Peter Budai wrote: >> Hi Alexey and Roumen, >> >> thanks for the feedback, let me Reply on the questions/issues. >> >> In order to be able to see exactly what is happening during the build, >> please see two separate CI process log: >> >> The first build log is the git master, without the patch: >> https://ci.appveyor.com/project/peterbud/mingw-packages/build/1.0.64 > Error is because is request static linking for application but objects > are build for dynamic linking. > > Configure script for mingw* host forces static linking of application > (It seems to me by mistake enable_static_linking is set to yes when > shared lib hack is removed). > > Lets set following snippet in script: > ..... > AC_ARG_ENABLE(static_linking, [ --enable-static-linking enable static > linking (no)]) > if test "z$enable_static_linking" = "zyes" ; then > XMLSEC_STATIC_BINARIES="-static" > AC_MSG_RESULT(yes) > else > AC_MSG_RESULT(no) > fi > ..... > > Linker flag -static requires some compilation magic : to set in > XMLSEC_APP_DEFINES preprocessor flags for static builds as is written in > documentation for instance > https://www.aleksey.com/xmlsec/api/xmlsec-notes-compiling-windows.html . > > So correction should be like this > ..... > XMLSEC_STATIC_BINARIES="-static" > XMLSEC_APP_DEFINES="$XMLSEC_APP_DEFINES -DXMLSEC_STATIC > -DLIBXSLT_STATIC -DLIBXML_STATIC" > .... > > Also created static libraries has to be checked for "zero import symbols". > > > Regards, > Roumen Petrov > > > > > > _______________________________________________ > xmlsec mailing list > xmlsec@aleksey.com > http://www.aleksey.com/mailman/listinfo/xmlsec > _______________________________________________ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec