On 2015-02-21, Will Herrmann wrote: > In the Input class, we have a number of methods such as the following (with > their Javadoc):
> - fromChannel(ReadableByteChannel c): Build a Source from a channel. > - fromFile(File f): Build a Source from a file. > - fromJaxb(Object jaxbObject): Build a Source from a Jaxb-Object. > - fromURI(URI uri): Build a Source from an URI. > These are all intuitive enough. Their names match the name of the class > that they take as input. And then we have these two: > - fromMemory(byte[] b): Build a Source from an array of bytes. > - fromMemory(String s): Build a Source from a string. > Unlike all of the other methods, the names of these two do not match the > names of the classes that they take as inputs. This is rather unintuitive > and I've seen it cause problems "in the field". Oh, that never occured to me. I don't see any problem with renaming them. Of course we'd need to adjust code internally but we are still in alpha so breaking things is totally fine. While we are talking about names (and I'm notoriously bad at naming), I think I posted this one: https://sourceforge.net/p/xmlunit/mailman/message/33305879/ Cheers Stefan ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Xmlunit-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xmlunit-general
