Christoph Scholtes wrote:
Hi,
Hi! Thanks for the patch!
[]
The conversion function for converting tag text according to
encoding
then returns an empty string (in my case). Note, these flags are
different for v3 and v4 of ID3v2.
Cool, do you have actual real life files with these flags set?
[]
This approach does not try to handle all flags possible but only those
which introduce additional
bytes into the frame.
It seems that you at least forgot the "grouping identity" flag. (a flag
that actually could easily be handled).
Also, the flags themselves are not handled, only
the bytes are skipped if the
flag is set.
As the format changes the flags indicate are not handled I don't really
see the point in the patch. And to handle decompression and decryption I
think the code needs to be refactored a bit more so this patch would
just be an unnecessary intermediate step.
I actually think that just doing something like this would be preferable.
diff --git a/src/plugins/id3v2/id3.c b/src/plugins/id3v2/id3.c
index b727baf..f5d2470 100644
--- a/src/plugins/id3v2/id3.c
+++ b/src/plugins/id3v2/id3.c
@@ -641,7 +641,9 @@ xmms_id3v2_parse (xmms_xform_t *xform,
flags = buf[8] | buf[9];
-if (buf[0] == 'T' || buf[0] == 'U' || buf[0] == 'A' || buf[0] == 'C') {
+if (buf[9] != 0) {
+ xmms_log_info ("Unsupported format flag in tag (%x)", buf[9]);
+} else if (buf[0] == 'T' || buf[0] == 'U' || buf[0] == 'A' || buf[0] ==
'C') {
handle_id3v2_text (xform, head, type, (gchar *)(buf + 10), flags, size);
}
--
_______________________________________________
Xmms2-devel mailing list
Xmms2-devel@lists.xmms.se
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
