Hi,

Adam Flott schrob:
> A patch is attached which turns off all output unless given --verbose. I hope
> that's what you were looking for.

Yes, thank you.

> @@ -92,10 +98,14 @@ main (int argc, char **argv)
>               if (res == -1)
>                       perror ("read");
>               if (res == 0) {
> -                     printf ("startup failed!\n");
> +                     if (verbose) {
> +                             printf ("startup failed!\n");
> +                     }
>                       exit (1);
>               }

Except this part, which will still exit(1) if xmms2d ist already
running, and won't print the error message if xmms2d genuinely failed to
start. It would be nice if xmms2-laucher was smart enough to detect
this, but failing that, I think dropping this part of the patch and
complaining loudly in either case would be better.

Thanks again,
    Jan
-- 
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments




--
_______________________________________________
Xmms2-devel mailing list
Xmms2-devel@lists.xmms.se
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel

Reply via email to