Changing line 19 in waftools/cython_extra.py from this:
raise CalledProcessError(retcode, cmd, output=output)
to this:
raise CalledProcessError(retcode, cmd)
Fixed the problem, but I'm not sure how to keep the old line when run
under Python3. It also changed the error to the actual exception, which
might be expected, but the lack of an exception handler makes it look
more like a Python error than a waf one:
Checking for program cython : /usr/bin/cython
Traceback (most recent call last):
...
File "waftools/cython_extra.py", line 20, in check_output
raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/usr/bin/cython', '-V']' returned
non-zero exit status 1
Indeed, the CalledProcessError signature has changed in 2.7. A solution
is to also copy the exception class from python 2.7 in cython_extra.py
(should be fixed in TEST3)
It looks like my Cython installation is broken, but either way I
would've expected the configure script to disable Cython/Python support
and keep going, rather than abort the whole process.
$ /usr/bin/cython -V
Traceback (most recent call last):
File "/usr/bin/cython", line 7, in <module>
from Cython.Compiler.Main import main
ImportError: No module named Cython.Compiler.Main
I must disagree about not aborting the process. Because it is not a
"configuration error". The configuration checks for dependencies and
compatibility, not for system consistency (It's the package manager's
job). Personally, I do expect the script to abort if my system is
broken. Then, you can explicitly disable the feature that requires the
broken package if you can't solve it: `./waf configure --no-cython` will
build python bindings using pre-generated files (which is the default
behaviour if cython is not installed at all).
--
Raphaël Bois
--
_______________________________________________
Xmms2-devel mailing list
[email protected]
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel
