Hi Lucas,

> OK, I just blindly merged it :-)

Thank you for your prompt action!

I'm afraid I've a couple more for you:

http://github.com/hellomatty/xmpp4r/commit/7daa90d0731e9d847dc73ee7d495d1a6b506780b

http://github.com/hellomatty/xmpp4r/commit/02317e87f45bf9ee3ad437fd76cdd137f8f8093e

This continues my attempt to clean up pubsub a little.

For the first I went back and validated the tests against the XEP,
fixing those that were broken or commented out. I also made sure the
ServiceHelper implementation was in line...

The second fixes style and whitespace issues from the first :-(

Next step is to fix up NodeHelper/ NodeBrowser. Actually I'm not too
sure how to test these as their methods are quite high level: each may
involve several trips to the server and back. Are there any examples
of how to use the state/ wait_state idiom in this kind of scenario?

Thanks in advance!

_______________________________________________
Xmpp4r-devel mailing list
[email protected]
https://mail.gna.org/listinfo/xmpp4r-devel

Reply via email to