On Tue, Feb 2, 2010 at 5:44 PM, Jeremy Huddleston <jerem...@freedesktop.org> wrote: > Instead, we warn where this optimization might cause a problem! > > This was included for historic reasons and has persisted to the point of now > infecting all X.org modules. Historically, it was just present in these > modules before adding XORG_CWARNFLAGS to XORG_DEFAULT_OPTIONS: > > libICE > libSM > libX11 > libXau > libXfont > libXft > libXpm > libXres > xorg-server > > Most of these modules probably don't even need to disable this optimization, > but if it is decided that this optimization should be disabled, it should be > restricted to the required module rather than a global option. > > Signed-off-by: Jeremy Huddleston <jerem...@apple.com> > --- > xorg-macros.m4.in | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in > index caf61c2..40f5939 100644 > --- a/xorg-macros.m4.in > +++ b/xorg-macros.m4.in > @@ -588,7 +588,7 @@ AC_DEFUN([XORG_CWARNFLAGS], [ > AC_REQUIRE([AC_PROG_CC]) > if test "x$GCC" = xyes ; then > CWARNFLAGS="-Wall -Wpointer-arith -Wstrict-prototypes > -Wmissing-prototypes \ > --Wmissing-declarations -Wnested-externs -fno-strict-aliasing \ > +-Wmissing-declarations -Wnested-externs -Wstrict-aliasing=2 \ > -Wbad-function-cast" > case `$CC -dumpversion` in > 3.4.* | 4.*) > -- > 1.6.2 > > > _______________________________________________ > xorg-devel mailing list > xorg-devel@lists.x.org > http://lists.x.org/mailman/listinfo/xorg-devel
Reviewed-by: Matt Turner <matts...@gmail.com> _______________________________________________ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel