On Thu, Apr 8, 2010 at 3:09 AM, Yaakov (Cygwin/X) <yselkow...@users.sourceforge.net> wrote: > On 2010-04-05 08:58, Dan Nicholson wrote: >> >> On Thu, Mar 25, 2010 at 4:12 PM, Yaakov (Cygwin/X) wrote: >>> >>> +# XORG_CHECK_SGML_DOCTOOLS >>> +# ------------------------ >>> +# Minimum version: 1.7.0 >>> +# >>> +# Defines the variable XORG_SGML_PATH containing the location of >>> X11/defs.ent >>> +# provided by xorg-sgml-doctools, if installed. >>> +AC_DEFUN([XORG_CHECK_SGML_DOCTOOLS],[ >>> +AC_MSG_CHECKING([for X.Org SGML entities]) >>> +XORG_SGML_PATH= >>> +PKG_CHECK_EXISTS([xorg-sgml-doctools], >> >> This should take an optional version number as an argument in case you >> need newer doctools or something. I think all it would take is this: >> >> PKG_CHECK_EXISTS([xorg-sgml-doctools] m4_ifval([$1], [>= $1]), ... > > Not quite, because if a minimum version is requested but not found then it > would fall back to the AC_CHECK_FILE which would still pass.
Huh, I hadn't noticed that. I think we should demand that you have the version with the .pc file once there's a release. For the very few people who are going to attempt to build the sgml documentation, I think they can be bothered to grab a newer doctools package. Not to mention that we very much should enforce version on defs.ent since it carries all the Xorg katamari information. It would suck to have someone build the docs saying that the Xorg release is 7.4 right now. I can't see any easy way to do this without the .pc file. -- Dan _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
