On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote: > > I'll reiterate an opinion stated here before. We should really try to > *reduce* the number of #ifdefs in the code base, not introduce new > ones.
In general you're right. We prefer clear code without these ugly #ifdefs all around. But this is not always the case and, I agree, a good justification is needed to introduce them. In our case, we don't want to employ libdrm in the device because it's simply not used. I don't care about the space that this library uses there, but I care about the maintenance that I'd have to do. And that counts a lot. Therefore, it's a tradeoff between this new feature causes too much trouble in the code (and honestly it's not!) and maintenance that myself I'll have to take. Tiago _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel