On Wed, Apr 28, 2010 at 4:51 PM, Peter Hutterer <[email protected]> wrote: > We call NIDR on all devices that make it through the config backend. > Including some that have no driver assigned to them (/dev/input/mouse0 for > example). Those ones then simply get ignored by NIDR, but this should not be > noted as an error in the log file. > > X_INFO is sufficient, and it may just prevent some bugreports. > > Signed-off-by: Peter Hutterer <[email protected]> > --- > hw/xfree86/common/xf86Xinput.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > index dba3370..a1a5527 100644 > --- a/hw/xfree86/common/xf86Xinput.c > +++ b/hw/xfree86/common/xf86Xinput.c > @@ -825,7 +825,7 @@ NewInputDeviceRequest (InputOption *options, > InputAttributes *attrs, > } > > if (!idev->driver || !idev->identifier) { > - xf86Msg(X_ERROR, "No input driver/identifier specified > (ignoring)\n"); > + xf86Msg(X_INFO, "No input driver/identifier specified (ignoring)\n"); > rval = BadRequest; > goto unwind; > }
Yep. I wanted to audit all the "fail" pathways from calling NIDR, but I haven't gotten to it. This is one of them, though. Reviewed-by: Dan Nicholson <[email protected]> _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
