drawable *is* pWin->drawable. i put the hunk insid ifdef ROOTLESS per your comment, but I wonder if miPaintwindow should return early in the general case if if is called with an UNDRAWABLE_WINDOW
Sent from my iPhone... On May 1, 2010, at 2:01, Keith Packard <[email protected]> wrote: > On Fri, 30 Apr 2010 16:22:07 -0700, Jeremy Huddleston <[email protected]> > wrote: > >> if (pWin->drawable->type == UNDRAWABLE_WINDOW) >> return; > > Ok, now I'm confused. The patch I see in your tree looks like this: > > @@ -552,6 +552,9 @@ miPaintWindow(WindowPtr pWin, RegionPtr prgn, int what) > DrawablePtr drawable = &pWin->drawable; > > #ifdef ROOTLESS > + if(!drawable || drawable->type == UNDRAWABLE_WINDOW) > + return; > + > if(IsFramedWindow(pWin)) { > RootlessStartDrawing(pWin); > RootlessDamageRegion(pWin, prgn); > > Are you talking about some other patch? > > -- > [email protected] _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
