On Wed, Aug 04, 2010 at 11:55:22PM -0700, Jesse Adkins wrote: > I also put this patch in bugzilla, in case it might help somebody in the > future. > > While I'm at it, can I get some thoughts about logging this as a warning or > informational. What about deprecating this feature?
> From e82132c1d1a6a182d2844ae3de30eb1409e3505c Mon Sep 17 00:00:00 2001 > From: Jesse Adkins <jesserayadk...@gmail.com> > Date: Wed, 4 Aug 2010 23:39:14 -0700 > Subject: [PATCH] xfree86: parser: Never use heap memory for driver names > (fixes #17438) > > When the parser sees the "keyboard" driver, it automatically (and > silently) replaces it with "kbd" (from heap). btw, the problem here is that we're _not_ using heap memory for the strings but constant strings instead. I've amended the message accordingly. Cheers, Peter > Everybody else uses malloc'd memory for the driver name, so input > device closure assumes it can use free. > Free val.str, so this crash doesn't turn into a memory leak. Whew. > > Signed-off-by: Jesse Adkins <jesserayadk...@gmail.com> _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
