On Tue, Sep 21, 2010 at 07:09:45PM +0200, ext Gaetan Nadon wrote:
> No function changes.
> 
> Note that automake generates a wrapper script if libpciaccess
> is not installed at configuration time, which is the most common case.
> 
> If it is installed at configuration time, you get an executable.
> 
> The makefile build order ensures the lib is build before scanpci.
> 
> The man page is moved to the man directory, as usual.
> 
> Signed-off-by: Gaetan Nadon <[email protected]>

I think your changes are nice, but I'd prefer to see those split up in two
patches instead: one to remove the wrapper script, using a proper makefile and
another to move code around, creating scanpci/ directory and man/


Thank you,

        Tiago
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to