In the original code if 'i' is equal to 10 then the line
   (void) memmove((char*)par, (char*)params, i * sizeof(String) );
moves ten things, which is okay.

The next line:
   bzero( &par[i], (10-i) * sizeof(String) );
moves zero things to a bad address, which is probably okay,
but I bet some code checker would complain.

The code is very ugly.

Pat
---
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to