On Wed, 2010-11-24 at 17:42 -0800, Dan Nicholson wrote: > On Wed, Nov 24, 2010 at 3:23 PM, Mark Kettenis <mark.kette...@xs4all.nl> > wrote: > >> From: Gaetan Nadon <mems...@videotron.ca> > >> Date: Tue, 23 Nov 2010 09:34:29 -0500 > >> > >> So far no one has claimed adding fPic is the correct way of creating a > >> shared lib or > >> that it is a necessary workaround to a situation libtool cannot handle > >> and that it will > >> work on all supported platforms. > > > > There certainly are platforms where -fPIC isn't the right choice. > > True, but libtool knows about these platforms and allows the user to > control it's usage with --with-pic. Seems better than blindly adding > -fPIC to the CFLAGS. >
I interpreted Mark's comment as confirming that -fPIC should not be added to CFLAGS as it would not be appropriate for all platforms. Perhaps Mark could comment on the patch you submitted, if not already done: http://lists.x.org/archives/xorg-devel/2010-November/015867.html > -- > Dan
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel