On 03/14/11 06:09 AM, Jon TURNEY wrote: > On 11/03/2011 22:37, Alan Coopersmith wrote: >> Makefile.am | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> New commits: >> commit ad5fefcc7a0a0beb1c02270d9f28c8b28da61199 >> Author: Alan Coopersmith <alan.coopersm...@oracle.com> >> Date: Fri Mar 11 14:10:19 2011 -0800 >> >> Make Makefile.am compatible with Solaris make >> >> Solaris make won't substitute $< in explicit rules, only implicit ones > > This change seems to break on my tinderbox, see [1], I think because it > doesn't work for builddir != srcdir builds? Perhaps the following is needed? > > --- a/Makefile.am > +++ b/Makefile.am > @@ -27,7 +27,7 @@ EXTRA_DIST = $(bin_SCRIPTS:=.in) > DIR_SUBSTS = -e 's|@bindir[@]|$(bindir)|g' > > mkfontdir: mkfontdir.in > - $(AM_V_GEN)$(SED) $(DIR_SUBSTS) < mkfontdir.in > $@ > + $(AM_V_GEN)$(SED) $(DIR_SUBSTS) < $(srcdir)/mkfontdir.in > $@ > > MAINTAINERCLEANFILES = ChangeLog INSTALL
Sorry - I remembered the $(srcdir) in most of those updates Friday, but guess I forgot in that one. Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com> -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel