Hi,

On Thu, Apr 14, 2011 at 12:31:00PM +1000, Peter Hutterer wrote:
> On Tue, Apr 12, 2011 at 09:58:57AM +0100, Daniel Stone wrote:
> > On Tue, Apr 12, 2011 at 11:05:56AM +1000, Peter Hutterer wrote:
> > > +    /* force alignment with double */
> > > +    union align_u { ValuatorClassRec valc; double d; } *align;
> > 
> > Errr ... why not just allocate valc->axes separately from valc?
> 
> mostly because this is the second half to Keith's patch
> 678f5396c91b3d0c7572ed579b0a4fb62b2b4655 and I'd rather have this in one
> location before I start changing the layout again. I don't know how many
> other places there are that rely on this to be one memory block.
> 
> It's a quickfix for a specific issue that'll hopefully become obsolete with
> the next input ABI.

OK.  In that case:
Acked-by: Daniel Stone <dan...@fooishbar.org>

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to