Am 08.07.2011 21:10, schrieb Kees Cook: > Hi, > > On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote: >> On Fri, Jul 8, 2011 at 11:01:45 -0700, Kees Cook wrote: >>> This replaces sprintf with snprintf to avoid crashing when creating >>> various labels. >>> >>> https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642 >>> >>> Signed-off-by: Kees Cook <kees.c...@canonical.com> >>> --- >>> xclipboard.c | 3 ++- >>> xcutsel.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 3 deletions(-) >>> >> asprintf or XtAsprintf maybe? > > I've been told in the past not use asprintf because it isn't portable, > and I do not find XtAsprintf in the include files: > > ../xclipboard/xclipboard.c:337:2: warning: implicit declaration of function > ‘XtAsprintf’ > ... > ../xclipboard/xclipboard.c:337: undefined reference to `XtAsprintf' > collect2: ld returned 1 exit status > > etc > > I'm not sure how I should proceed. :P >
I like asprintf() ntl, i think snprintf is better here because the is no use if the label name is too long. re, wh _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
