On Mon, Sep 26, 2011 at 12:56:45PM +0200, Max Schwarz wrote: > Hi Peter, > > Am Monday, 26. September 2011, 16:11:05 schrieb Peter Hutterer: > > sorry, I completely forgot about that. > No problem at all. Your approach is certainly more flexible than mine ever > was. > I like the idea of doing both-way emulation in the server, that removes the > need to create both type of events in the drivers. > > > Any comment on the smooth scrolling approach is appreciated, we're not final > > yet on the protocol. > I'm playing around with your code (your next-all branch) here, and it looks > very good. I sent in a patch about the double/fraction conversion yesterday, > maybe you've seen it. Without it the valuators always report integer values.
yes, I've seen it. unfortunately I'm a bit swamped with some other stuff atm so my patch review lag is high. > Additionally I got a compile error about redefinitions of "XF86OptionPtr" on > your branch, I had to guard the typedefs with preprocessor guards. A small > patch is here, though it's certainly better to look at why redefinitions > occur: > https://gist.github.com/d0828f2e99b36ec01340 > If you need additional information on that, mail me. yes, I found this yesterday as well but more by accident. gcc 4.6 allows duplicate typedefs and doesn't warn about them unless -pedantic is given. So the code that compiles fine on F15 blew up on RHEL6. I've got a patch that moves the XF86OptionRec out into a separate header that will hit the list shortly. > I'm currently working on getting smooth scrolling working with wheel > emulation > in xf86-input-evdev, so I can test the 'smooth' part of the whole thing. I > will probably send you a patch today if you are interested. I want to avoid > working on the same parts you are working on though, that wouldn't be very > productive. There is already an smooth-scrolling branch on people.freedesktop.org/~whot/xf86-input-evdev, you're best off just using that. It doesn't work with wheel emulation yet though and I don't really have any plans (or time) to work on it. So feel free to add to this. Cheers, Peter > I think I will focus on the client side of this after wheel emulation. Your > patchset covers the X.org side quite nicely ;-) > My old Qt4 patch should be easy to adopt, and I have got an idea about how to > proceed with GTK as well. > > Best regards, > Max _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel