For the series (1-7): Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com>
Though 5 could use a little more explanation in the commit message, such as a mention of how the return value is becoming void because no caller used it and that the old msb_set static checked by each caller is replaced by the p.hae static checked in sethae() when it's called. (If you look at the code carefully enough you can figure that out, as I did, but we greatly appreciate commit messages that help people understand the code more quickly, both during review now and years later when trying to track down changes. http://who-t.blogspot.com/2009/12/on-commit-messages.html ) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
