On 10/20/2011 01:47 AM, Marko Myllynen wrote:
Hi,
On 2011-10-18 20:15, Matt Dew wrote:
On 10/17/2011 03:07 AM, Marko Myllynen wrote:
There's a comment in the keysymdef.h file:
ezh/EZH happened to be in ranges covered by IPAExt_upper_mapping and
LatinExtB_{upper,lower}_mapping mappings in KeyBind.c already but indeed
permille needed a mapping in src/xlibi18n/imKStoUCS.c as was done for
partialderivative in commit c859446c500c883a67f7a86cab1a44844e24dade.
I've now tested by building patched libX11 against the updated
keysymdef.h and ezh/EZH/permille work in compose maps and keyboard map
files as expected.
I'm attaching an updated patch to update the comment section, a patch
for the needed mapping in libX11, and, while at it, updating compose
maps to use the ezh/EZH mnemonics.
It's not my area of expertise so I probably won't catch anything but
glaring errors. But I didn't see any of those so:
Reviewed-by: Matt Dew<mar...@osource.org>
Did you want to take a stab at updating the keysyms.xml?
right, when I updated the documentation references I forgot to follow
the documented procedure myself :)
I'm attaching updated patches, the only change is the addition of the
permille to keysyms.xml.
Looks like there's quite a few missing from the XML file. (Does anyone
know) Is the goal of the XML file to have all of the ones that are in
the .h file?
Regardless, looks good.
Reviewed-by: Matt Dew<mar...@osource.org>
Thanks,
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
