On Nov 8, 2011, at 1:35 PM, Gaetan Nadon wrote: > On Thu, 2011-11-03 at 01:19 -0700, Jeremy Huddleston wrote: > >> See: https://bugs.freedesktop.org/show_bug.cgi?id=31238 >> >> Signed-off-by: Jeremy Huddleston <jerem...@apple.com> >> --- >> xorg-macros.m4.in | 47 >> ++++++++++++++++++++++++++++++++++++++++++++++- >> 1 files changed, 46 insertions(+), 1 deletions(-) >> >> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in >> index 123bdaa..7de333c 100644 >> --- a/xorg-macros.m4.in >> +++ b/xorg-macros.m4.in >> @@ -1430,12 +1430,54 @@ m4_foreach([flag], m4_cdr($@), [ >> ]) >> ]) # XORG_TESTSET_CFLAG >> >> +# XORG_COMPILER_FLAGS >> +# --------------- >> +# Minimum version: 1.16.0 >> +# >> +# Defines BASE_CFLAGS to contain a set of command line arguments >> supported >> +# by the selected compiler which do NOT alter the generated code. >> These >> +# arguments will cause the compiler to print various warnings during >> +# compilation AND turn a conservative set of warnings into errors. >> +# >> +# The set of flags supported by BASE_CFLAGS will grow in future >> +# versions of util-macros as options are added to new compilers. >> +# >> +AC_DEFUN([XORG_COMPILER_FLAGS], [ > > > I am late for the review, but I looked at the last 3 patches in the > series and I don't see a problem. Overall a nice cleanup as well. > > So I should soon be seeing an xserver patch replacing CWARNFLAGS with > BASE_CFLAGS.
Yep, but I'm going to let this sit for a little while first. I want my hw/dmx patch and alanc's warning fixup series to land before we release util-macros-0.16 ... after that, I'll provide a patch for xorg-server and start going through the rest of the modules as well. _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
