On Thu, 2011-11-17 at 07:43 -0800, Alan Coopersmith wrote: > Those are bugs then, they should all use $(datadir). > > I know I've had to override some in the past when building distro > packages, but I thought we'd gotten all those fixes in to git by > now.
No, they must NOT go into $(datadir)/pkgconfig. Here's why: Presume that you install the *proto/xtrans headers/templates into /usr/include and the .pc files into /usr/share/pkgconfig, then proceed to use these headers to cross-compile another X.Org component with a sysroot-capable cross-toolchain, pkg-config will kindly add a -I/usr/include to your CFLAGS. This will cause the native system headers to be picked up instead of the cross-target libc headers, causing all sorts of compile errors. Furthermore, <X11/Xfuncproto.h> and <X11/Xpoll.h> (from xproto) and xtrans.pc have system-dependent substitutions, so they cannot be used for cross-compiling. Therefore, regarding the original patch: Reviewed-by: Yaakov Selkowitz <yselkow...@users.sourceforge.net> Yaakov Cygwin/X _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
