For the series: Reviewed-by: Jamey Sharp <ja...@minilop.net>
Nice work. :-) On Sun, Dec 11, 2011 at 10:16:13AM -0800, Alan Coopersmith wrote: > Removes 422 lines of warning messages from the xserver build when > using gcc 4.5.2 on Solaris 11 with the latest xorg-macros set of > warning flags, and does not introduce any new warnings. > > There's still plenty more to fix after this batch of course. > > Alan Coopersmith (25): > CheckForEmptyMask does not need to declare int n twice > Fix deconstifying cast warning in xi2_get_type > Use const cast in BitIsOn macro to avoid angering gcc > verify_internal_event: preserve constness of data pointer > constify strings in resource name registry > xres.c: Preserve constness of string returned by LookupResourceName > os/access.c: replace acmp & acopy macros with memcmp & memcpy calls > Constify string for authorization protocol names > Constify the reason string throughout the authorization check > framework > OsInit: store "/dev/null" in a const char * > WriteToClient: preserve constness of buf while extracting length > value > LockServer: store path to LOCKDIR literal string in a const char * > xdmcp.c: fix three small const warnings > CompareISOLatin1Lowered: constify arguments > x86emu: constify debug strings > DoShowOptions: preserve constness of options list as we walk it > Convert KdDoSwitchCmd to use asprintf instead of malloc/strcat/etc. > KdParseFindNext: Constify delim argument > XkbFindSrvLedInfo: remove extraneous name-clashing sli variable > _XkbFilterDeviceBtn: move variable declarations to match usage scope > Remove duplicate declaration of xf86ValidateModesFlags in xf86Modes.h > Remove duplicate declarations of KdAdd*Driver in kdrive.h > xf86Priv.h: Add some noreturn attributes suggested by gcc > Add some printf format attributes suggested by gcc > xf86 parser: convert Error to a varargs macro to clear gcc format > warnings > > Xext/security.c | 5 +- > Xext/xres.c | 4 +- > dix/cursor.c | 2 +- > dix/dispatch.c | 5 +- > dix/dixutils.c | 4 +- > dix/events.c | 2 +- > dix/inpututils.c | 2 +- > dix/registry.c | 5 +- > dix/resource.c | 2 +- > hw/kdrive/src/kdrive.c | 15 ++---- > hw/kdrive/src/kdrive.h | 8 +--- > hw/xfree86/common/xf86.h | 2 +- > hw/xfree86/common/xf86Config.c | 2 +- > hw/xfree86/common/xf86Configure.c | 5 +- > hw/xfree86/common/xf86Priv.h | 6 +-- > hw/xfree86/common/xf86Xinput.h | 2 +- > hw/xfree86/modes/xf86Modes.h | 4 -- > hw/xfree86/parser/Configint.h | 4 +- > hw/xfree86/parser/DRI.c | 4 +- > hw/xfree86/parser/Device.c | 4 +- > hw/xfree86/parser/Extensions.c | 2 +- > hw/xfree86/parser/Files.c | 2 +- > hw/xfree86/parser/Flags.c | 4 +- > hw/xfree86/parser/Input.c | 4 +- > hw/xfree86/parser/InputClass.c | 4 +- > hw/xfree86/parser/Layout.c | 28 ++++++------ > hw/xfree86/parser/Module.c | 4 +- > hw/xfree86/parser/Monitor.c | 84 ++++++++++++++++++------------------ > hw/xfree86/parser/Pointer.c | 8 ++-- > hw/xfree86/parser/Screen.c | 36 ++++++++-------- > hw/xfree86/parser/Vendor.c | 6 +- > hw/xfree86/parser/Video.c | 6 +- > hw/xfree86/parser/configProcs.h | 4 +- > hw/xfree86/x86emu/debug.c | 4 +- > hw/xfree86/x86emu/fpu.c | 16 ++++---- > hw/xfree86/x86emu/ops2.c | 4 +- > hw/xfree86/x86emu/x86emu/debug.h | 4 +- > include/dix.h | 4 +- > include/inputstr.h | 2 +- > include/os.h | 6 +- > include/registry.h | 2 +- > include/resource.h | 2 +- > os/access.c | 30 ++++++------- > os/auth.c | 6 +- > os/connection.c | 4 +- > os/io.c | 2 +- > os/mitauth.c | 2 +- > os/osdep.h | 2 +- > os/osinit.c | 2 +- > os/rpcauth.c | 2 +- > os/utils.c | 4 +- > os/xdmauth.c | 4 +- > os/xdmcp.c | 6 +- > render/filter.c | 3 +- > xkb/xkbActions.c | 9 ++-- > xkb/xkbLEDs.c | 6 +-- > 56 files changed, 194 insertions(+), 211 deletions(-) > > -- > 1.7.3.2 > > _______________________________________________ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel
signature.asc
Description: Digital signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel