On 01/02/2012 06:06 PM, Chase Douglas wrote:
On 01/02/2012 05:54 PM, Jeremy Huddleston wrote:
Also, the tinderbox currently does make use of the existing unit tests in the server by
running 'make check' after the build. I assume we could easily add these new unit tests
to 'make check' and it will "just work"
Correct. In Makefile.am, you would add a new xorg-gtest derived
executable to the TESTS variable (and noinst_PROGRAMS so it's not
installed). Then define the sources and such for the executable.
Automake will build and execute the test program when "make check" is
performed.
I personally really like how the Jenkins interface looks, so I don't
think it would be bad to convert from tinderbox. However, that's the
true extent of my knowledge, which isn't enough to make a real decision
with :). The path of least resistance is likely just adding any new
tests to 'make check' and letting tinderbox go about as-is.
Having it in 'make check' also ensures that keithp runs it before
pulling patches.
The one issue with xorg-gtest and a dummy server is that the server must
be run as root. This is because the dummy.conf file is installed in a
non-standard location (for obvious reasons). Does it still make sense to
limit the configuration file locations for non-root users? Should we add
a -dummy flag to Xorg so we don't need a dummy.conf file?
-- Chase
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
