Hi, On Fri, Dec 02, 2011 at 07:17:24PM -0200, Paulo Zanoni wrote: > 2011/12/2 Daniel Stone <dan...@fooishbar.org>: > > @@ -90,6 +104,9 @@ load_extension_config(void) > > } > > #endif > > } > > + > > + for (i = 0; i < ARRAY_SIZE(extensionModules); i++) > > + LoadExtension(&extensionModules[i], TRUE); > > } > > > > void > > With this statement, Xorg will try to load its modules twice. Maybe it > was added by accident? Don't forget to remove the "int i" declaration > too. > > Look: > http://cgit.freedesktop.org/~daniels/xserver/tree/hw/xfree86/common/xf86Extensions.c?h=extension-cleanup&id=2c4cb57dfa2e37ef910be298c2bcbb9731e5f137#n108 > > xf86ExtensionInit will call load_extension_config, which will do that > loop quoted above (line 108). Then, at line 119 xf86ExtensionInit will > run the same loop again.
Looks like I only responded to this on IRC, oops. I've fixed this a while ago now. > I cloned your full git tree, and Xorg was not starting because of > that. After I removed exactly the lines I quoted, Xorg starts and I > can login and play OpenArena (but I didn't test too much). I also > checked that simple Xorg startup/shutdown without clients doesn't > introduce any new memory leaks, and it also accidentaly fixes a memory > leak because you removed LoaderSortExtensions. > As a side note, don't we get a faster server startup after all this? > Did anyone measure? > > I'll keep running your tree to see if I find anything else. Thanks. :) I haven't measured startup times, no; I'll try to get something concrete later. Cheers, Daniel _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel