When the benchmarks are run as non-root, they terminate since they can't read the drm files. However, by terminating with abort(), this raises SIGSEGV which has the side effect of triggering crash reporting utilities (e.g. apport). As a result we've been accumulating bug reports about it.
As the code is displaying a unique error message prior to termination, it should be discoverable enough where in the code the failure occurs, so an exit(1) should be sufficient for termination. Signed-off-by: Bryce Harrington <br...@canonical.com> --- lib/drmtest.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index fc40ad1..5ebd6d6 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -65,7 +65,7 @@ int drm_open_any(void) close(fd); } fprintf(stderr, "failed to open any drm device. retry as root?\n"); - abort(); + exit(1); } @@ -108,5 +108,5 @@ int drm_open_any_master(void) return fd; } fprintf(stderr, "Couldn't find an un-controlled DRM device\n"); - abort(); + exit(1); } -- 1.7.4.1 _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel