On 03/22/12 02:50 AM, Tomas Carnecky wrote:
> These two patches replace all custom inline keywords with a plain `inline`,
> while still maintaining backwards compatibility through a autoconf macro.

For both patches:
Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com>

And I'm in favor of the concept in general, but before anyone goes off to
do this to all our other modules, I do think we need to stick to use of
_X_INLINE in headers exposed to clients.   For any internal headers,
server-side headers, or direct use in .c files, using just plain inline &
requiring AC_C_INLINE is great, but we know there's a ton of existing X
clients which aren't built with autoconf or C99 compilers, and we don't
want to break them.

-- 
        -Alan Coopersmith-              alan.coopersm...@oracle.com
         Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to