On 04/04/2012 07:18 PM, Alan Coopersmith wrote: > On 04/ 4/12 03:29 PM, Chase Douglas wrote: >> This option specifies a file descriptor in the launching process. X >> will scan for an available display number and write that number back to >> the launching process, at the same time as SIGUSR1 generation. This >> means display managers don't need to guess at available display numbers. >> As a consequence, if X fails to start when using -displayfd, it's not >> because the display was in use, so there's no point in retrying the X >> launch on a higher display number. >> >> Signed-off-by: Adam Jackson <a...@redhat.com> >> Signed-off-by: Chase Douglas <chase.doug...@canonical.com> >> Reviewed-by: Julien Cristau <jcris...@debian.org> >> Tested-by: Julien Cristau <jcris...@debian.org> >> --- >> Changes since v2: >> * Use snprintf instead of sprintf (in both locations) >> * Add a comment about how the display global variable is set > > Thanks. (I do note that you removed the \n from the display and > didn't add it to the write of the display to the fd - I don't know > if that matters or not, so figured I'd mention it.)
Oh, I forgot to mention the change. Thanks for catching it. I don't see any reason the '\n' should be necessary. -- Chase _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel