On 04/20/2012 03:15 PM, Alan Coopersmith wrote: > On 04/20/12 03:11 PM, Chase Douglas wrote: >> On 04/20/2012 03:06 PM, Alan Coopersmith wrote: >>> On 04/20/12 02:56 PM, Chase Douglas wrote: >>>> On 04/20/2012 02:35 PM, Alan Coopersmith wrote: >>>>> On 04/20/12 02:18 PM, Chase Douglas wrote: >>>>>> XauFileName() may allocate and return a static buffer. The only >>>>>> way to ensure it is freed is to deallocate it when the program exits. >>>>> >>>>> ...at which point it's automatically freed. Is this just trying to >>>>> silence some sort of memory leak checking? >>>> >>>> Yes. I'm running valgrind and trying to solve leaks. I realize this is >>>> not a "real" issue, but it's essentially like a compiler warning. >>>> Reducing warnings and errors helps highlight where there are real problems. >>> >>> Right, just trying to make sure that I understood what problem you were >>> trying to solve (quieting false positives so real problems are easier to >>> find), and the patch seems to be a reasonable way to do that, so: >>> >>> Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com> >> >> So libXau is listed as unmaintained: >> >> http://cgit.freedesktop.org/xorg/doc/xorg-docs/tree/MAINTAINERS#n176 >> >> but I see you have been applying patches. Will you be picking this up? I >> can apply it, too. Either way. > > You can go ahead and push directly. I tend to worry more about picking up > patches from people without direct git write access.
Done. Thanks! -- Chase _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
