On 07/26/13 02:23 PM, Thomas Klausner wrote:
These patches mirror the commit history of changes done to
xf86-input-keyboard in the NetBSD xsrc repository (except perhaps
for timing between patches for different files).
I'm willing to squash or edit patches to reduce the number of diffs;
please advise on what you want combined in this way.
Other suggestions welcome too, for example for patch 21's autoconf
code for machine architecture detection.
For patches 1-7, 9-11, while I can't verify you've chosen the right
values for those keycodes, I assume you and your users have already tested
that out, and since the way you've set them looks fine:
Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com>
Patches 8, 12, 18, seem to require more platform specific knowledge
than I have of your platform. They don't seem wrong, I just don't know if
they're right. Since they're credited to other authors, would you consider
yourself to have reviewed them and be willing to offer up the r-b for them?
Patches 13, 15, 21 I replied directly to with comments before giving r-b.
Patches 14, 16, 17, 19, 20 seem simple enough to review without platform
knowledge, and look fine to me, so those can also have:
Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com>
Since this is a huge pile of patches, and you've been upstreaming a lot lately,
is it time to discuss git commit access so you can push them yourself instead
of having to wait both for someone to review and for a committer to push?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
