Hi, On 01/28/2014 08:52 AM, David Herrmann wrote: > Hi Peter > > On Tue, Jan 28, 2014 at 8:15 AM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: >> On Wed, Jan 15, 2014 at 03:32:22PM +0100, Hans de Goede wrote: >>> This commits add the bulk of the systemd-logind integration code, but does >>> not hook it up yet other then calling its init and fini functions, which >>> don't do that much.
<snip> >>> @@ -902,6 +903,26 @@ if test "x$CONFIG_HAL" = xyes; then >>> fi >>> AM_CONDITIONAL(CONFIG_HAL, [test "x$CONFIG_HAL" = xyes]) >>> >>> +if test "x$SYSTEMD_LOGIND" = xauto; then >>> + if test "x$HAVE_DBUS" = xyes -a "x$CONFIG_UDEV" = xyes ; then >>> + SYSTEMD_LOGIND=yes >>> + else >>> + SYSTEMD_LOGIND=no >>> + fi >>> +fi >>> +if test "x$SYSTEMD_LOGIND" = xyes; then >>> + if ! test "x$HAVE_DBUS" = xyes; then >>> + AC_MSG_ERROR([systemd-logind requested, but D-Bus is not >>> installed.]) >>> + fi >>> + if ! test "x$CONFIG_UDEV" = xyes ; then >>> + AC_MSG_ERROR([systemd-logind is only supported in >>> combination with udev configuration.]) >>> + fi >>> + >>> + AC_DEFINE(SYSTEMD_LOGIND, 1, [Enable systemd-logind integration]) >>> + NEED_DBUS="yes" >>> +fi >>> +AM_CONDITIONAL(SYSTEMD_LOGIND, [test "x$SYSTEMD_LOGIND" = xyes]) >>> + >> >> this looks a bit odd - don't we need to check for some systemd-specific bits >> as >> well here? if not, or if we're already checking for it, maybe note that in >> the commit message. > > For the dbus-stuff it's fine to not check for any systemd stuff, but > the patch uses systemd/sd-login.h so we definitely need to check via > pkg-config here. Actually sd-login.h is not used at all, it is a left over from some earlier experiments, I've removed it in my local tree. Regards, Hans _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
